Remove states UI options in group integration #32021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
core
has-tests
integration: group
small-pr
|
Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration ( |
balloob
reviewed
Feb 20, 2020
| @@ -257,7 +244,7 @@ def groups_with_entity(hass: HomeAssistantType, entity_id: str) -> List[str]: | |||
|
|
|||
| extra_arg = { | |||
| attr: service.data[attr] | |||
| for attr in (ATTR_VISIBLE, ATTR_ICON, ATTR_VIEW, ATTR_CONTROL) | |||
| for attr in (ATTR_ICON) | |||
There was a problem hiding this comment.
Now you're iterating over each character in the string, one comma is all the difference…
Suggested change
| for attr in (ATTR_ICON) | |
| for attr in (ATTR_ICON,) |
There was a problem hiding this comment.
Are we on top of this, to fix it?
There was a problem hiding this comment.
Sorry, seeing the notification just now. Adjusting.
There was a problem hiding this comment.
Not sure why I merged this without being addressed 🤦♂
There was a problem hiding this comment.
Before coffee ☕️ 😉
All good now 👍
balloob
approved these changes
Feb 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Group configurations options, services and service options related to the old states UI were deprecated in 0.105 and now removed.
This includes:
viewandcontrolconfiguration options for a group.group.set_visibilityservice callcontrol,visible,viewoptions on thegroup.setservice call.Please ensure your configuration and automations don't use these anymore.
Proposed change
Remove states UI options in group integration, deprecated in 0.105: #30831
Documentation was already removed on initial deprecation.
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: